refactor(providers): canonicalize model-router calls by WebMad · Pull Request #1165 · Zoo-Code-Org/Zoo-Code

WebMad · 2026-08-05T21:08:26Z

Summary

use the shared providerIdentifiers registry for model-router provider options and cache calls
canonicalize OpenRouter endpoint routing, LM Studio/Kimi Code/Requesty/Unbound/Poe cache access, and webview router candidates and filters
preserve all existing serialized and wire provider values

Validation

npx vitest run api/providers/__tests__/poe.spec.ts api/providers/fetchers/__tests__/modelEndpointCache.spec.ts core/webview/__tests__/webviewMessageHandler.routerModels.spec.ts — 28 tests passed
pnpm run check-types in src — passed
repository pre-commit lint — passed
repository pre-push type checks — passed

Related to #944 (remaining-work item 4).

Summary by CodeRabbit

Bug Fixes
- Improved model discovery, caching, and provider selection across supported services, including LM Studio, OpenRouter, Kimi Code, Poe, Requesty, and Unbound.
- Standardized provider handling in model requests and settings to improve consistency for provider-specific workflows.
- Corrected Gemini model information display to show the appropriate billing estimate.
Tests
- Added coverage confirming billing estimates appear correctly for supported Gemini models.

coderabbitai · 2026-08-05T21:09:04Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cc6db751-6933-4b64-a5c2-c810434bf76b

📥 Commits

Reviewing files that changed from the base of the PR and between d0af4c0 and ac0b8f2.

📒 Files selected for processing (13)

src/api/providers/fetchers/lmstudio.ts
src/api/providers/fetchers/modelEndpointCache.ts
src/api/providers/kimi-code.ts
src/api/providers/lm-studio.ts
src/api/providers/openrouter.ts
src/api/providers/poe.ts
src/api/providers/requesty.ts
src/api/providers/unbound.ts
src/core/webview/webviewMessageHandler.ts
webview-ui/src/components/settings/ModelInfoView.tsx
webview-ui/src/components/settings/ModelPicker.tsx
webview-ui/src/components/settings/__tests__/ModelInfoView.spec.tsx
webview-ui/src/components/settings/constants.ts

📝 Walkthrough

Walkthrough

Provider model fetching, cache handling, webview routing, and settings now use shared providerIdentifiers constants. Provider maps use computed identifier keys, and a Gemini billing-message test was added.

Changes

Provider identifier centralization

Layer / File(s)	Summary
Centralize settings provider values `webview-ui/src/components/settings/constants.ts`, `webview-ui/src/components/settings/ModelInfoView.tsx`, `webview-ui/src/components/settings/ModelPicker.tsx`, `webview-ui/src/components/settings/__tests__/ModelInfoView.spec.tsx`	Provider maps, provider values, Gemini checks, and Mimo hints now use shared identifiers. The Gemini billing message has a rendering test.
Update provider fetcher lookups `src/api/providers/fetchers/*`, `src/api/providers/kimi-code.ts`, `src/api/providers/lm-studio.ts`, `src/api/providers/openrouter.ts`, `src/api/providers/poe.ts`, `src/api/providers/requesty.ts`, `src/api/providers/unbound.ts`	Model discovery and cache operations now use shared identifiers for supported providers.
Canonicalize webview provider routing `src/core/webview/webviewMessageHandler.ts`	Model initialization, candidate construction, cache flushing, filtering, and Ollama or LM Studio request options now use shared identifiers.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Zoo-Code-Org/Zoo-Code#1109: Centralizes provider identifiers in settings and runtime model handling.
Zoo-Code-Org/Zoo-Code#1141: Migrates the same settings components to shared provider identifiers.
Zoo-Code-Org/Zoo-Code#1020: Updates provider-string comparisons and model-cache logic to use shared identifiers.

Suggested labels: awaiting-review

Suggested reviewers: edelauna, navedmerchant

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: canonicalizing provider model-router calls.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/api/providers/fetchers/lmstudio.ts

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

src/api/providers/fetchers/modelEndpointCache.ts

ESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox.

src/api/providers/kimi-code.ts

ESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox.

10 others

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

codecov · 2026-08-05T21:11:10Z

Codecov Report

❌ Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/core/webview/webviewMessageHandler.ts	77.77%	4 Missing ⚠️
src/api/providers/fetchers/lmstudio.ts	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

WebMad added 4 commits August 5, 2026 15:34

refactor(webview): complete provider identifier migration

84cdb1c

test(webview): type selected model hook mocks

74d9f56

test(webview): keep selected model spec out of provider migration

3219853

refactor(providers): canonicalize model router calls

ac0b8f2

WebMad requested review from JamesRobert20, edelauna, hannesrudolph, navedmerchant and taltas as code owners August 5, 2026 21:08

coderabbitai Bot mentioned this pull request Aug 5, 2026

refactor(providers): reuse retired Roo identifier #1166

Open

Navigation Menu

Uh oh!

refactor(providers): canonicalize model-router calls - #1165

refactor(providers): canonicalize model-router calls#1165
WebMad wants to merge 4 commits into
Zoo-Code-Org:mainfrom
WebMad:refactor/944-canonicalize-model-router-calls

WebMad commented Aug 5, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 5, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

codecov Bot commented Aug 5, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

WebMad commented Aug 5, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

codecov Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

WebMad commented Aug 5, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 5, 2026 •

edited

Loading

codecov Bot commented Aug 5, 2026 •

edited

Loading